Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical scroll not working anymore in 4.0.0-alpha.0 #465

Closed
BrodaNoel opened this issue Aug 29, 2023 · 10 comments
Closed

Vertical scroll not working anymore in 4.0.0-alpha.0 #465

BrodaNoel opened this issue Aug 29, 2023 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@BrodaNoel
Copy link
Contributor

Describe the bug
The bugs reported and fixed in #143 and #125, is not working anymore.

In version 3.x.x, this fix worked properly:

            panGestureHandlerProps={{
              activeOffsetX: [-10, 10],
            }}

But in 4.0.0-alpha.0 is not working

To Reproduce
I think it's clear from the other issues

Expected behavior
It should let me scroll vertically the in the ScrollView, when I put my finger on top of the carousel

Screenshots
N/A

Versions (please complete the following information):
"react": "18.2.0",
"react-native": "0.72.3",
"react-native-fbsdk-next": "^12.1.0",
"react-native-gesture-handler": "~2.12.0",
"react-native-maps": "1.7.1",
"react-native-purchases": "^5.16.0",
"react-native-reanimated": "~3.3.0",
"react-native-reanimated-carousel": "4.0.0-alpha.0",

Smartphone (please complete the following information):

  • Device: iPhone and Android (happens in all of them). I tested it on iPhone 13 mini, and an old Huawei
  • OS: iOS 16.6, and android 9.1

Additional context
N/A

@BrodaNoel BrodaNoel added the bug Something isn't working label Aug 29, 2023
@BrodaNoel
Copy link
Contributor Author

BrodaNoel commented Aug 29, 2023

Oh! Yes, there is an additional context:

I'm using it inside a Modal.

The modal (partial) code is:

import { Modal as RNModal } from 'react-native';
import { GestureHandlerRootView, TouchableOpacity } from 'react-native-gesture-handler';

<RNModal animationType="slide" onRequestClose={this.onClose}>
  <GestureHandlerRootView style={styles.root}>
    <ScrollView
        style={{ flex: 1, backgroundColor: '#fff' }}
        contentContainerStyle={{
          paddingBottom: 8 + insets.bottom,
        }}
        keyboardShouldPersistTaps="always"
        onScrollBeginDrag={onScrollBeginDrag}
      >
        {this.props.children}
      </ScrollView>
  </GestureHandlerRootView>
</RNModal>

@hk-skit
Copy link

hk-skit commented Oct 12, 2023

@dohooo Can you please help on this? Thanks.

@0xFA11
Copy link

0xFA11 commented Oct 23, 2023

+1, it breaks one of the basic interactions, I hope to see this get fixed.

@BrodaNoel
Copy link
Contributor Author

Any news here? It seems like the PR is done. We just need the merge & deploy

@YuGer26
Copy link

YuGer26 commented Oct 30, 2023

I'm also waiting for this fix, activeOffsetX doesn't work

@ravirajcm
Copy link

Do we have any update on this issue?

@julienqueffelec
Copy link

same here 🙁

@hk-skit
Copy link

hk-skit commented Nov 8, 2023

@oliverloops Can you please help on this? Thanks.

@BrodaNoel
Copy link
Contributor Author

Fixed with the new implementation after alpha1

onConfigurePanGesture={gestureChain => {
              gestureChain.activeOffsetX([-10, 10]);
            }}

@qwertychouskie
Copy link

Fixed with the new implementation after alpha1

onConfigurePanGesture={gestureChain => {
              gestureChain.activeOffsetX([-10, 10]);
            }}

Works great on iOS and Android, but doesn't work on Web. Any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants