Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some textures flickering in "The Saboteur" game (d3d9) #1560

Closed
rox4d opened this issue Apr 7, 2020 · 9 comments
Closed

Some textures flickering in "The Saboteur" game (d3d9) #1560

rox4d opened this issue Apr 7, 2020 · 9 comments
Labels

Comments

@rox4d
Copy link

rox4d commented Apr 7, 2020

There are some textures flickering in definite locations (in general game are playable).

Software information

Saboteur.exe (from GOG)

System information

  • GPU: ACO POLARIS11 (LLVM 10.0.0)

  • Driver: AMD RADV (mesa build from git)

  • Wine version: wine-5.5 (Staging)
    Снимок экрана в 2020-04-07 12-30-28

  • DXVK version: v1.6-28-g3f4ffdf

Apitrace file(s)

Log files

@WinterSnowfall
Copy link
Contributor

It looks good to me on DXVK v1.7, so you may want to recheck.

The_Saboteur

It could also be an issue with RADV.

@rox4d
Copy link
Author

rox4d commented Jun 3, 2020

Looks so, just retested with dxvk v1.7-40-g5558460 - no changes here.

@rox4d
Copy link
Author

rox4d commented Jun 3, 2020

WinterSnowfall - trace replaying fine for you? (it may be different with game, i suppose).

@WinterSnowfall
Copy link
Contributor

WinterSnowfall - trace replaying fine for you? (it may be different with game, i suppose).

Yes, your trace also looks good on my GTX 1080. I see no flickering.

@CME42
Copy link
Contributor

CME42 commented Jun 3, 2020

It's a precision error that only happens on AMD, both radv and amdvlk, d3d9.invariantPosition = True doesn't help.

@Blisto91
Copy link
Contributor

Blisto91 commented Mar 31, 2022

Just a quick update that this is still present on mesa git. Looking into making a mesa issue if that can help.

Edit: Upstream mesa issue

@Blisto91
Copy link
Contributor

Blisto91 commented Apr 2, 2022

Comment from the mesa issue

"This isn't a RADV issue as far as I can tell. It's caused by DXVK's D24 emulation using D32. AMD doesn't support D24, nvidia does. If I force DXVK to always use D32 I can reproduce the issue on nvidia."

@K0bin
Copy link
Collaborator

K0bin commented Jun 11, 2022

This is probably caused by the depth bias.

First it draws this with a depth bias:
image

This this mesh without one:
image

@K0bin
Copy link
Collaborator

K0bin commented Jun 20, 2023

Fixed by #3501

@K0bin K0bin closed this as completed Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants