Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F1 2018 corruption on characters in CG #1897

Closed
JaxLinAMD opened this issue Jan 15, 2021 · 13 comments
Closed

F1 2018 corruption on characters in CG #1897

JaxLinAMD opened this issue Jan 15, 2021 · 13 comments
Labels

Comments

@JaxLinAMD
Copy link

Operating System : Ubuntu 20.04
ASIC : Navi 10
DRIVER : amdvlk https://github.com/GPUOpen-Drivers/AMDVLK

setup steam
Set resolution to 1920x1080
Set quality to Ultra High
When entering time trial mode choose "Classic F1 Cars" otherwise corruption is obscured by car cockpit view.

@JaxLinAMD
Copy link
Author

add barrier in generated SPIRV can workaround this issue.

@doitsujin
Copy link
Owner

Which shader exactly?

We generate barriers when the orginal DirectX shader contains barriers. If there is none, this is a game bug.

@JaxLinAMD
Copy link
Author

JaxLinAMD commented Jan 15, 2021

do you need the spirv file or renderdoc capture?
is the tool to convert dx shader to spriv wrote by yourself or thirdparty?

@doitsujin
Copy link
Owner

The SPIR-V so I can correllate it to the original shader.

@JaxLinAMD
Copy link
Author

spirv.zip

@JaxLinAMD
Copy link
Author

*_edited.dis shows where I added barriers

@doitsujin
Copy link
Owner

Same bug as in F1 2019. We have a workaround for that already which we can enable for both games.

@JaxLinAMD
Copy link
Author

Hi @doitsujin thank you for this. I have steam proton environment now, could you tell me how to verify with the workaround you enabled? can I replace some dx binaries of steam proton?

@doitsujin
Copy link
Owner

DXVK binaries are located in .steam/steam/steamapps/common/Proton 5.13/dist/lib64/wine/dxvk and can just be replaced.

@JaxLinAMD
Copy link
Author

thank ya!

@JaxLinAMD
Copy link
Author

hi @doitsujin when building dxvk, I encountered following errors:

In file included from ../../../../../root/Downloads/dxvk-master/src/dxgi/dxgi_adapter.cpp:8:
../../../../../root/Downloads/dxvk-master/src/dxgi/dxgi_factory.h:13:41: error: ‘IDXGIFactory7’ was not declared in this scope; did you mean ‘IDXGIFactory2’?
13 | class DxgiFactory : public DxgiObject {
do you know how to resolve it?

@doitsujin
Copy link
Owner

doitsujin commented Jan 19, 2021

The latest MinGW release (8.0, not to be confused with the GCC version which should be 10.2) ships up to date DXGI headers which are required to build DXVK.

@JaxLinAMD
Copy link
Author

thanks, it works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants