Generic EXE names in util/config/config.cpp

[Tiagoquix]

Hi there.

The file https://github.com/doitsujin/dxvk/blob/master/src/util/config/config.cpp has generic EXE names, which makes me think that we should use more folder-based paths to apply fixes. As far as I understand it, DXVK can also be used to run normal apps (and not only games), so generic names (generally short names) may cause conflict for some apps (or, even, for non-related games) due to the fact that the fixes are applied globally to a specific EXE name.

Some examples below.

---

dxvk/src/util/config/config.cpp

Lines 20 to 23 in c2fd91f

	/* Assassin's Creed Syndicate: amdags issues */
	{ R"(\\ACS\.exe$)", {{
	{ "dxgi.customVendorId", "10de" },
	}} },

dxvk/src/util/config/config.cpp

Lines 130 to 133 in c2fd91f

	/* SteamVR performance test */
	{ R"(\\vr\.exe$)", {{
	{ "d3d11.dcSingleUseMode", "False" },
	}} },

dxvk/src/util/config/config.cpp

Lines 170 to 173 in c2fd91f

	/* Atelier Firis */
	{ R"(\\A18\.exe$)", {{
	{ "d3d9.deferSurfaceCreation", "True" },
	}} },

dxvk/src/util/config/config.cpp

Lines 190 to 193 in c2fd91f

	/* Nights of Azure */
	{ R"(\\CNN\.exe$)", {{
	{ "d3d9.deferSurfaceCreation", "True" },
	}} },

dxvk/src/util/config/config.cpp

Lines 238 to 242 in c2fd91f

	/* Crazy Machines 3 - crashes on long device *
	* descriptions */
	{ R"(\\cm3\.exe$)", {{
	{ "dxgi.customDeviceDesc", "DXVK Adapter" },
	}} },

dxvk/src/util/config/config.cpp

Lines 262 to 269 in c2fd91f

	/* God of War - relies on NVAPI/AMDAGS for *
	* barrier stuff, needs nvapi for DLSS */
	{ R"(\\GoW\.exe$)", {{
	{ "d3d11.ignoreGraphicsBarriers", "True" },
	{ "d3d11.relaxedBarriers", "True" },
	{ "dxgi.hideNvidiaGpu", "False" },
	{ "dxgi.maxFrameLatency", "1" },
	}} },

---

And many others.

As much as, until then, I have not seen any report because of the generic EXE names, I still think we should remedy them and avoid them as much as possible.

Thank you for your attention.

[Blisto91]

We would have to be careful though so as not to regress anything.
There is a small chance that if a game is available on different stores it might have different folder name or structure. Or if a game have a old retail version that have changed those with time through updates or when added to a digital store later. Though this is probably pretty uncommon.

Adding a folder would also mean the config wouldn't apply to a game if a user or modder decided to change the name of the game folder. If that is even something we want to take in to consideration

[Tiagoquix]

You have very valid points.

For newer fixes, as I suggested, if the name looks a little too generic, then we should use folder-based paths (Steam being the priority here for folder paths, if the game install is different on EOS and/or other stores).

As of now, I don't see anyone having an issue with the generic names, because the majority of users use DXVK to play games. But it's a nice thing to keep an eye on.

[doitsujin]

Which of these exe names are used in more than one game?

The regex approach we use already supports install folders, but unless there are known instances of a config unintentially applying to a different game, changing these is just going to cause more harm than good (e.g. if a game uses a different directory on GoG/EGS than on Steam).

[Tiagoquix]

Which of these exe names are used in more than one game?

Currently, I can't tell you if there are any games that suffer from this problem.

My idea was to create an issue to make the problem more visible.

Considering the previous comments, and considering that I also agree with them, I will be closing the issue.

Specific cases of games having problems due to a fix from another game being applied should be reported in individual issues in the future.