Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A broken test builde returns with exit code zero #209

Closed
szwoelf opened this issue Feb 13, 2018 · 3 comments
Closed

A broken test builde returns with exit code zero #209

szwoelf opened this issue Feb 13, 2018 · 3 comments
Milestone

Comments

@szwoelf
Copy link

szwoelf commented Feb 13, 2018

Enhancement

When building tests with dojo build -m test the return code to the operating system is zero even if the build process fails.

Package Version: 0.5.0

Expected behavior:

A non zero return code will possibly be more appropriate and ensure that the build breaks a CI build chain.

@szwoelf
Copy link
Author

szwoelf commented Feb 23, 2018

This is also true if linting fails.
Here also the build continues ... possibly this is desired but on automatic builds it is unexpected.

@agubler
Copy link
Member

agubler commented Mar 27, 2018

This works for all commands provided they don't swallow errors, unfortunately cli-build-app does not return an error back to the CLI when there has been a build failure - will need to add changes to cli-build-app to ensure this returns back as expected on a failure.

@szwoelf
Copy link
Author

szwoelf commented May 5, 2018

Thank you for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants