Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential axes work #9

Open
11 tasks
novemberborn opened this issue Aug 22, 2016 · 0 comments
Open
11 tasks

Potential axes work #9

novemberborn opened this issue Aug 22, 2016 · 0 comments

Comments

@novemberborn
Copy link
Contributor

The createAxesMixin is far from complete:

  • It assumes datum values are >= 0 for horizontal axes (no negative values), but <= is supported for vertical axes
  • Axes configuration cannot be provided through the widget state. This would also require label selectors to be defined on the prototype since they can't be serialized into the state. Perhaps as topInputLabelSelector, etc
  • Axes configuration cannot be provided through the prototype. This is necessary to create widgets with a default configuration
  • It's unclear how a default configuration would be extended through options and/or state
  • Certain configuration may be default for all enabled axes (e.g. ticks). Would be cool not to have to repeat that
  • Chart dimensions are not adjusted if exceeded by grid lines
  • No support for "mini ticks". These should probably be restricted to range based axes, where the step size must be a multiple of the mini tick interval
  • Consider center (vertical) and middle (horizontal) axes for charts with negative values
  • Our targeted IE versions may not support dominant-baseline. If we know the line-height we may be able to polyfill the currently limited set of allowed values, or maybe we need to support a perpendicularOffset option and remove dominantBaseline
  • We may need perpendicularOffset anyhow (e.g. for the bottom axis it would move the label down, for the left axis it would move it further left)
  • Axes tend to draw duplicate ticks and grid lines for the "zero" position
@dylans dylans modified the milestone: 2017.04 Jan 24, 2017
@dylans dylans modified the milestones: 2017.05, 2017.04 Apr 7, 2017
@dylans dylans modified the milestones: 2017.05, 2017.06 May 30, 2017
@eheasley eheasley modified the milestones: long-grass, 2017.06 Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants