Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default StoreProvider key to state #261

Closed
tomdye opened this issue Feb 18, 2019 · 0 comments
Closed

Default StoreProvider key to state #261

tomdye opened this issue Feb 18, 2019 · 0 comments
Labels
bug Something isn't working enhancement New feature or request needs back-port The fix requires back porting to one or more previous major versions next Issue/Pull Request for the next major version

Comments

@tomdye
Copy link
Member

tomdye commented Feb 18, 2019

Enhancement

registerStoreInjector defaults the store key to state, but the StoreProvider implementation does not. If we default the key used by StoreProvider to state it would provide a better symmetry with the register command and remove the need to place the state string throughout the code base.

current defaulting here: https://github.com/dojo/framework/blob/master/src/stores/StoreInjector.ts#L123
@tomdye tomdye added bug Something isn't working enhancement New feature or request next Issue/Pull Request for the next major version needs back-port The fix requires back porting to one or more previous major versions labels Feb 18, 2019
@agubler agubler mentioned this issue Feb 23, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request needs back-port The fix requires back porting to one or more previous major versions next Issue/Pull Request for the next major version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomdye