Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving widget-core to core #280

Closed
matt-gadd opened this issue Mar 1, 2019 · 3 comments
Closed

Moving widget-core to core #280

matt-gadd opened this issue Mar 1, 2019 · 3 comments
Labels
discussion The issue is up for discussion

Comments

@matt-gadd
Copy link
Contributor

matt-gadd commented Mar 1, 2019 •
edited
Loading

Enhancement

When we started working on widget-core, we wanted to call it core but unfortunately core already existed as a lot of modules transferred over from the initial dojo to dojo2 transition. Given since then we have effectively removed all those legacy things and we have a total 4 utility modules left in core, it's difficult to see why this would exist anymore on it's own. In which case we could move those 4 utility modules over to widget-core, and rename widget-core to core
@matt-gadd matt-gadd added the discussion The issue is up for discussion label Mar 1, 2019
@tomdye
Copy link
Member

tomdye commented Mar 1, 2019

Sounds like a good idea to me.

@agubler
Copy link
Member

agubler commented Mar 1, 2019

Given that it should be a trivial migration for cli-upgrade-app and framework/widget-core being the true core suite of the framework modules, this makes sense to me.

@agubler agubler mentioned this issue Mar 22, 2019
Closed
3 tasks
@agubler
Copy link
Member

agubler commented May 31, 2019

Closed by #357

@agubler agubler closed this as completed May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion The issue is up for discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merges widget-core into core. agubler/framework
3 participants
@tomdye @agubler @matt-gadd