Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the framework does not mutate VNodes and WNodes #289

Closed
agubler opened this issue Mar 7, 2019 · 0 comments · Fixed by #290
Closed

Ensure that the framework does not mutate VNodes and WNodes #289

agubler opened this issue Mar 7, 2019 · 0 comments · Fixed by #290
Labels
breaking change Indicates the issue/pull request would result in a breaking change enhancement New feature or request

Comments

@agubler
Copy link
Member

agubler commented Mar 7, 2019

Enhancement

VNode and WNode are decorated with a bind property that holds the instance of the widget that originally returned it from its render. This is problematic as it inadvertently gives access to widget instances by accessing the bind property, widget instances should not be exposed to end users as instance management is entirely controlled by the framework's vdom renderer.

Considerations:

  • bind is used to add the DOMNode to the node handler which powers DOM based metas
  • bind is used to auto bind property functions to the widget instance that created the DNode

The WNode is also modified when a widget registry item is available, with the widgetConstructor being updated to reference the registry item.

The goal is to ensure that VNodes and WNodes should not be mutated by the framework.

@agubler agubler changed the title Move bind from VNode and WNode Ensure that the framework does not mutate VNodes and WNodes Mar 7, 2019
@agubler agubler added enhancement New feature or request breaking change Indicates the issue/pull request would result in a breaking change labels Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Indicates the issue/pull request would result in a breaking change enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant