Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Rest store #124

Closed
wants to merge 2 commits into from
Closed

Rest store #124

wants to merge 2 commits into from

Conversation

maier49
Copy link
Contributor

@maier49 maier49 commented Apr 6, 2017

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:
Adds an implementation of the Storage interface for storing data on a server with a RESTful API. This is on top of the changes in #118.

Resolves #47, #100

@maier49 maier49 mentioned this pull request Apr 6, 2017
@codecov
Copy link

codecov bot commented Apr 6, 2017

Codecov Report

Merging #124 into master will decrease coverage by 0.05%.
The diff coverage is 99.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   99.92%   99.86%   -0.06%     
==========================================
  Files          16       17       +1     
  Lines        1351     1517     +166     
  Branches      249      288      +39     
==========================================
+ Hits         1350     1515     +165     
- Partials        1        2       +1
Impacted Files Coverage Δ
src/store/materialize.ts 100% <ø> (ø) ⬆️
src/query/createStoreRange.ts 100% <ø> (ø) ⬆️
src/patch/createOperation.ts 100% <100%> (ø) ⬆️
src/store/StoreBase.ts 100% <100%> (ø) ⬆️
src/storage/IndexedDBStorage.ts 100% <100%> (ø) ⬆️
src/store/QueryableStore.ts 100% <100%> (ø) ⬆️
src/query/createFilter.ts 100% <100%> (ø) ⬆️
src/store/ObservableStore.ts 100% <100%> (ø) ⬆️
src/query/CompoundQuery.ts 100% <100%> (ø) ⬆️
src/store/createStoreObservable.ts 100% <100%> (ø) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42557c9...3ec5b9e. Read the comment docs.

@maier49 maier49 mentioned this pull request Apr 7, 2017
7 tasks
@dylans dylans added this to the 2017.04 milestone Apr 7, 2017
@maier49 maier49 mentioned this pull request Apr 21, 2017
7 tasks
@dylans dylans modified the milestones: 2017.04, 2017.05 Apr 29, 2017
@dylans
Copy link
Member

dylans commented May 19, 2017

This one also needs a rebase and then finally a review.

@maier49
Copy link
Contributor Author

maier49 commented May 23, 2017

Rebased. These PRs should all start passing CI once #133 gets merged and rebased.

maier49 added 2 commits May 24, 2017 11:28
Updating rest store implementation - wip

Working tests

Support alternate names for items property, and add tests

Wip

Make test name capitalization consistent, test configurable timeout

Add support for JSON merge patch and improve test coverage

* Adds support for the JSON Merge Patch format

* Add tests for new functionality

* Removed an unneeded branch in the default fetch response
serializer, as it won't receive falsy data.
@eheasley eheasley modified the milestones: 2017.05, 2017.06 Jun 6, 2017
@dylans dylans modified the milestones: 2017.06, 2017.07 Jul 4, 2017
@dylans dylans modified the milestones: 2017.07, 2017.08 Jul 29, 2017
@kitsonk kitsonk modified the milestones: 2017.08, 2017.09 Sep 4, 2017
@kitsonk kitsonk removed this from the 2017.08 milestone Sep 4, 2017
@kitsonk kitsonk modified the milestones: 2017.09, long-grass Oct 6, 2017
@agubler
Copy link
Member

agubler commented Nov 7, 2017

Closing since the latest version of stores has landed

@agubler agubler closed this Nov 7, 2017
@maier49 maier49 deleted the rest-store branch November 14, 2017 16:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants