Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build throws syntax errors for ES6+ code even when transforming back to ES3 #89

Open
estermer opened this issue Nov 2, 2021 · 0 comments

Comments

@estermer
Copy link

estermer commented Nov 2, 2021

Look like this is a recurring issue but I wanted to open this anyways.

for reference:
Stack Overflow Question
Dojo Bug Ticket

It is my understanding that by adding optimizeOptions with languageIn/languageOut (which are also defaulted) the Closure Compiler will transform the ES6+ code to an earlier version of ECMAScript.

When we do this, it looks like in the process of the build, there is a util/build/transform/depsScan to see if the module and its deps are "Pure AMD" BEFORE the transformation of langIn -> langOut happens.

Is it absolutely necessary to keep the order of the gates as is, or can we reorder them so that the transformation to ES5- happens first and then the AST depsScan happens next?

Is there a status on how to solve this issue? Or should I just live with all the console errors and ignore them since what is a syntax error is being transformed anyways?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant