Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Meta Base invalidate() should not require instance context #708

Open
kitsonk opened this issue Oct 6, 2017 · 0 comments
Open

Meta Base invalidate() should not require instance context #708

kitsonk opened this issue Oct 6, 2017 · 0 comments

Comments

@kitsonk
Copy link
Member

kitsonk commented Oct 6, 2017

Enhancement

As noted in a PR, the meta Base calls an invalidate() passed in during the construction properties, but the way it calls it requires its context to be the instance:

protected invalidate(): void {
this._invalidate();
}

When trying to invalidate a meta instance though from within something like an event handler, it is a common situation that the protected method will lose its context. This requires downstream meta implementors to statically bind to the proper context to call a passed property that is already statically bound from the implementing widget. We should find a way to ensure that the Base.invalidate() works without having to statically bind to the instance.

@kitsonk kitsonk added this to the 2017.10 milestone Oct 6, 2017
@kitsonk kitsonk modified the milestones: 2017.10, beta.4 Oct 30, 2017
@kitsonk kitsonk added beta5 and removed beta4 labels Oct 30, 2017
@kitsonk kitsonk modified the milestones: beta.4, beta.5 Oct 30, 2017
@agubler agubler removed the beta5 label Jan 4, 2018
@agubler agubler removed this from the beta.5 milestone Jan 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants