Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip theme css.js files for coverage #165

Merged
merged 1 commit into from
May 5, 2017

Conversation

agubler
Copy link
Member

@agubler agubler commented May 5, 2017

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Should skip the generated css.js themes files for coverage.

@agubler agubler changed the title skip theme css js files for coverage Skip theme css.js files for coverage May 5, 2017
@codecov
Copy link

codecov bot commented May 5, 2017

Codecov Report

Merging #165 into master will increase coverage by 7.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
+ Coverage    91.7%   99.45%   +7.75%     
==========================================
  Files          30       18      -12     
  Lines        1001      923      -78     
  Branches      278      278              
==========================================
  Hits          918      918              
+ Misses         78        0      -78     
  Partials        5        5
Impacted Files Coverage Δ
_build/themes/dojo/select.m.css.js
_build/themes/dojo/radio.m.css.js
_build/themes/dojo/checkbox.m.css.js
_build/themes/dojo/tabPane.m.css.js
_build/themes/dojo/slidePane.m.css.js
_build/themes/dojo/comboBox.m.css.js
_build/themes/dojo/textarea.m.css.js
_build/themes/dojo/button.m.css.js
_build/themes/dojo/dialog.m.css.js
_build/themes/dojo/textinput.m.css.js
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c30eab...e45934e. Read the comment docs.

@agubler agubler merged commit 3456a5c into dojo:master May 5, 2017
@dylans dylans added this to the 2017.05 milestone May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants