Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Content to a Widget outside of Text #272

Closed
kitsonk opened this issue Aug 11, 2017 · 1 comment
Closed

Adding Content to a Widget outside of Text #272

kitsonk opened this issue Aug 11, 2017 · 1 comment
Milestone

Comments

@kitsonk
Copy link
Member

kitsonk commented Aug 11, 2017

User Story

As a developer, I may need to add and style non-text content to a widget with said content being just for display purposes, not affecting the function or behaviour of the widget.

Specific Use Case

I want to add a save icon to a button, which is supplied from a FontAwesome stylesheet.

Specific Use Case

Using the @dojo/widget ComboBox, I want to change the down arrow to a plus sign.

@kitsonk kitsonk added this to the 2017.08 milestone Aug 11, 2017
@kitsonk kitsonk added the beta3 label Aug 11, 2017
@kitsonk kitsonk modified the milestones: 2017.08, 2017.09 Sep 4, 2017
@eheasley eheasley added beta4 and removed beta3 labels Oct 3, 2017
@eheasley eheasley modified the milestones: 2017.09, 2017.10 Oct 6, 2017
@bitpshr
Copy link
Member

bitpshr commented Oct 20, 2017

The current story around this type of component modification isn't great. If a component doesn't explicitly expose a particular piece of its inner content as a property, a consumer can only reliably modify that piece of content through direct component extension. New patterns like offloading most heavy-lifting from the main render method to small helper render methods (#316) will make this type of direct extension easier to swallow across the board.

There's also the possibility of making much better use of the registry available in each component, but this approach is limiting. For example, unless the ComboBox's down arrow is contained within a child component (and not just raw vdom), there wouldn't be any actual component available to stub out using the registry.

I'm not sure there's anything actionable from this discussion beyond #316.

Action items:

  • Close this ticket

@bitpshr bitpshr closed this as completed Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants