Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing onmouseup action to something else in DatePicker radio buttons #532

Closed
krezovic opened this issue Apr 2, 2018 · 1 comment
Milestone

Comments

@krezovic
Copy link

krezovic commented Apr 2, 2018

Bug

Package Version: RC1

Trying to use Calendar in MSIE 11, with the theme from @dojo/themes. Thing is, MSIE 11 does not support appearance property, so the current "trick" used in the theme that works on all other browsers won't work there.

And if I set radio button to disabled via CSS, it never gets onmouseup event, but does get onchange event due to clicking on the label, which is currently being used. That results in Year/Month dropdown never being closed, and calendar being rendered buggy.

I've tried to move the function call from onmouseup event into onchange handler, and it seems to work here. Not sure why is onmouseup being used, but I guess there's a good reason.

Please provide a solution that will also work on IE11 with hidden radio button as in @dojo/themes (with something other than css:appearance property).

@smhigley
Copy link
Contributor

smhigley commented Apr 9, 2018

Can't reproduce on IE11 after adding opacity: 0 to the radio inputs. It cannot close on the onChange event, since that would result in the menu being closed every time a keyboard user arrowed to a new month or year.

There are two other issues with the Calendar, which might be obfuscating the issue:

  1. IE11 styling problems, issue here: Dojo theme needs review on IE11 themes#16
  2. Cross-browser menu bugs, issue here: Calendar month/year picker bugs #535

Closing this issue for now, but feel free to reopen if the IE11 bug is still present after the above issues are resolved.

@smhigley smhigley closed this as completed Apr 9, 2018
@dylans dylans added this to the 2018.04 milestone Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants