Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sozo] Add Deploy Account functionality #1574

Closed
ponderingdemocritus opened this issue Feb 22, 2024 · 5 comments · Fixed by #1601
Closed

[sozo] Add Deploy Account functionality #1574

ponderingdemocritus opened this issue Feb 22, 2024 · 5 comments · Fixed by #1601
Assignees
Labels
blocked This issue is blocked due to some other issues contributor good first issue Good for newcomers help wanted Extra attention is needed sozo
Milestone

Comments

@ponderingdemocritus
Copy link
Contributor

As we move closer to production, we need to simplify the process for developers to create accounts on live networks.

Currently, Starkli offers the best developer experience for this on Starknet. However, the dojo stack is different, so we should integrate some functionality directly into Sozo.

Account Management
Sozo should enable a developer to create an account, store it in a keystore locally, and then deploy it after funding it through a faucet. This workflow, used by Starkli, is effective.

Since Scarb.toml is checked into repositories, we should follow Starkli's approach and store these in ciphertext. This means we would need to use this account instead of the Scarb.toml account if it exists.

Therefore, this task involves:

  1. Enabling the deployment and management of accounts via Sozo similar to Starkli.
  2. Managing accounts via Sozo using a ciphertext store locally, to avoid exposing these values in the Scarb.toml.
@ponderingdemocritus ponderingdemocritus added good first issue Good for newcomers help wanted Extra attention is needed sozo labels Feb 22, 2024
@JimmyFate
Copy link
Contributor

Hey :)
I could give this a try

@glihm
Copy link
Collaborator

glihm commented Feb 22, 2024

Hey :) I could give this a try

Hey @JimmyFate are you already with an idea to how you will tackle this?

Don't hesitate if you have any question. The guideline here is:

  1. Check how starkli handles the account and keystore files. They are two separate concerns. @ponderingdemocritus we also want to integrate all the signer logic right?
  2. Then into sozo, you will find the organization of the binary with the commands (which parses the inputs) and then the ops, where the actual implementation of the behavior is.

Sounds good to you?

@ponderingdemocritus
Copy link
Contributor Author

Yes we need signer logic too - sozo does already support some of this

@ponderingdemocritus ponderingdemocritus added this to the 1.0.0 milestone Feb 29, 2024
@tarrencev tarrencev changed the title [sozo] Add Deploy Account functionality [sozo] Add Deploy Account functionality Mar 5, 2024
@glihm
Copy link
Collaborator

glihm commented Mar 6, 2024

Hey @JimmyFate, are you still working on this one?

@JimmyFate
Copy link
Contributor

Hey @JimmyFate, are you still working on this one?

Hey, there's an open pull request

@glihm glihm added the contributor label Mar 11, 2024 — with Linear
@glihm glihm added the blocked This issue is blocked due to some other issues label Apr 11, 2024 — with Linear
@github-project-automation github-project-automation bot moved this to Done in Dojo Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue is blocked due to some other issues contributor good first issue Good for newcomers help wanted Extra attention is needed sozo
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants