-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sozo] expose fee multiplier for sozo migrate
#1801
Comments
Fee multiplier already exist in the dojo/bin/sozo/src/commands/options/transaction.rs Lines 6 to 13 in 64fa43c
iirc |
Yeah good point, I think it was a regression here. I've added it back into #1802. From the conversation we had in the discord with the community, I think we should add in the Will open an issue for this next task if you agree. |
Yeah, we thought about adding this before when we're adding the multiplier flag. Sounds good to me |
Will close in this one is favor of #1808. |
Is your feature request related to a problem? Please describe.
sozo migrate
command does have a fee multiplier in the code, but it's not exposed to the user.This can cause trouble when migrating to a Katana with fees activated or a Starknet network.
Describe the solution you'd like
In a first step, this PR should expose the fee multiplier to the user.
In a second PR, we may want to use the raw fee or fee multiplier, introduced in #1601.
Additional context
The
apply_diff
function has aTxConfig
which contains a fee multiplier field.It is set to
None
. The modification should make this field coming from the CLI.dojo/crates/sozo/ops/src/migration/mod.rs
Lines 275 to 280 in f0637f9
The text was updated successfully, but these errors were encountered: