Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sozo] Merge FeeOptions into TransactionOptions #1887

Closed
notV4l opened this issue Apr 26, 2024 · 2 comments · Fixed by #1927
Closed

[sozo] Merge FeeOptions into TransactionOptions #1887

notV4l opened this issue Apr 26, 2024 · 2 comments · Fixed by #1927
Assignees
@lambda-0x
Labels
enhancement New feature or request good first issue Good for newcomers sozo

Comments

@notV4l
Copy link
Collaborator

notV4l commented Apr 26, 2024 •
edited by lambda-0x
Loading

Is your feature request related to a problem? Please describe.
Merge FeeOptions into TransactionOptions

FeeOptions was added in #1601 and to not block that PR for longer we merge it, but ideally we should use already existing option TransactionOption since we already use it in other places, so merge we need to merge both of them into single option TransactionOptions which has all features related to configuring the transaction.
@notV4l notV4l added enhancement New feature or request good first issue Good for newcomers sozo labels Apr 26, 2024
@lambda-0x lambda-0x changed the title [sozo] add --fee-estimate-multiplier param to sozo account deploy [sozo] Merge FeeOptions into TransactionOptions Apr 26, 2024
@glihm
Copy link
Collaborator

glihm commented Apr 26, 2024

@lambda-0x this is related to DOJ-366 right? Will assign to you.

@lambda-0x
Copy link
Collaborator

@notV4l updated issue description for easier understanding, merging both of them would mean we support --fee-estimation-multiplier as well.

This was referenced Apr 28, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lambda-0x lambda-0x

Labels
enhancement New feature or request good first issue Good for newcomers sozo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dev(sozo): use TransationOption instead of FeeOption dojoengine/dojo
3 participants
@glihm @lambda-0x @notV4l