Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[torii] Panic when updating cursor #2654

Closed
edisontim opened this issue Nov 7, 2024 · 0 comments · Fixed by #2655
Closed

[torii] Panic when updating cursor #2654

edisontim opened this issue Nov 7, 2024 · 0 comments · Fixed by #2655

Comments

@edisontim
Copy link
Contributor

edisontim commented Nov 7, 2024

In a scenario where we're subscribed to event_messages updates and to the torii relay (the issue doesn't occur when not subscribed to ws, I believe), the QueryType::UpdateCursors crashes on this line

num_transactions / (now.elapsed().as_secs() - cursor_timestamp)

in this scenario I believe we need to calculate the difference between now and the cursor's timestamp but the current code subtracts the time difference between the moment we created the now and the cursor's timestamp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants