Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use variable REDIS_URL if another one use REDIS_URL in its name, ex: WONDER_REDIS_URL #250

Open
grizmio opened this issue Jul 22, 2024 · 0 comments

Comments

@grizmio
Copy link

grizmio commented Jul 22, 2024

Description of problem

Can't use variable REDIS_URL if another one use REDIS_URL in its name, ex: WONDER_REDIS_URL
For weird reasons out of my control, our project uses REDIS_URL for REDIS and CELERY_REDIS_URL in the same container.
It would be easier to have meetings with all projects manager and I am currently working on it but it slow as hell.
Currently the plugin check if REDIS_URL is present in the list as string of one line is present, so it thinks WONDER_REDIS_URL is REDIS_URL every time I link redis with the app. If I use the flag -a REDIS_URL it believes it already exists

How reproducible

Just use an APP with a variable FOO_REDIS_URL setted to any value and try to link redis to it

Actual Results

The plugin uses DOKKU_REDIS_AQUA_URL

Expected Results

Link the app using REDIS_URL

How (deb/make) and where (AWS, VirtualBox, physical, etc.) was Dokku installed?:

dokku was installed from github

Additional information

root@claritywave-transicion-staging:~# dokku redis:info xxxxxxxxxxxxxxx-redis
=====> xxxxxxxxxxxxxxx-redis redis service information
       Config dir:          /var/lib/dokku/services/redis/xxxxxxxxxxxxxxx-redis/config
       Config options:                               
       Data dir:            /var/lib/dokku/services/redis/xxxxxxxxxxxxxxx-redis/data
       Dsn:                 redis://:5c7fxxxxxxxxxxxxxxxxa2e0b5@dokku-redis-xxxxxxxxxxxxxxx-redis:6379
       Exposed ports:       -                        
       Id:                  ae02708xxxxxxxxxxxxxxxxxxxxb0bc
       Internal ip:         172.17.0.8               
       Initial network:                              
       Links:               unificacion-staging      
       Post create network:                          
       Post start network:                           
       Service root:        /var/lib/dokku/services/redis/xxxxxxxxxxxxxxx-redis
       Status:              running                  
       Version:             redis:7.2.4              

I wrote a quick ugly fix that im currently using and made a pull request in hopes someone with better skills than mine could make a proper fix.
#249
Thanks for taking time to read this and sorry about my bad english.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant