Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Review-app with a clone of the db for migrations checks #99

Open
mattions opened this issue Feb 24, 2025 · 1 comment
Open

Improve Review-app with a clone of the db for migrations checks #99

mattions opened this issue Feb 24, 2025 · 1 comment

Comments

@mattions
Copy link
Contributor

Hi all,

Given the last PR that got merged: #95 , I was thinking we could offer additional capabilities to it.

For example, in our case, we would use that, but only if if we could run the PR as a full copy of production, to basically set up an automatic staging environment everytime we have a PR ready to go.

This means, at least in my mind, there is a big difference on the database approach:

at the moment the strategy is to clone the app, which re-use the Production database.
Instead I would like to have:

Create review App

create review-app
detach production database
clone production database into review-database
link cloned review-database to review-app
standard deploy on the new review app

This should provide the ability to also test the migrations and all th that jazz connected with the DB, without touching the original DB

Delete review App

detroy review-app and connected review-database

I understand that:

  1. some apps may not have a database connected.
  2. if the apps has massive DB, the cloning is not something that can be done in a full approach, and most likely does not make sense to have a full stage with all the data.

TBH, I do not know all the implications, this is more a discussion and see if there is interest and if it even makes sense, or we should simply suggest to have dedicated, laser-focused strategy, without trying to come up with a general solution.

@josegonzalez
Copy link
Member

Not sure what you're asking here specifically. Can you clarify?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants