-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade [or others?] with ' - ' in their name don't parse correctly #23
Comments
First pass at fix: |
It's a bit buggy; don't take the code yet. |
Improved w/ paulpv@d5aa032 In general the whole |
Perhaps it isn't with "Ships", but "Upgrades". I have edited my original comment to state this. |
Ah yes, I think I noticed something about that a while back and forgot about it (don't often check CCUs) Excellent. Will take a look next chance I get. And yes, the whole thing is rather fragile - that's why there's a big "correction" section in the Processing file that attempts to standardize CIGs naming to some extent. The splits and regexes only cover 90% of scenarios - the other 10% we have to fix manually :'( And that's before we get to the differences between "packages", and "add-ons". |
I suspect this will be resolved in v2 that was just released @paulpv - it's quite a refactor though, but it's designed to standardize the ship codes / manufacturer codes to match up with docs.starcitizen.fans so Erkul and FleetViewer can share/import the data HangarXPLOR exports |
Upgrades that have a ' - ' in their ship name don't parse correctly:
Examples:
"SHIP UPGRADES - CYCLONE TO TUMBRIL - NOVA TANK UPGRADE"
"SHIP UPGRADES - ORIGIN X1 - VELOCITY TO ORIGIN X1 - FORCE UPGRADE"
"SHIP UPGRADES - ORIGIN X1 TO ORIGIN X1 - FORCE UPGRADE"
The problem is a combination of
var titleParts = pledgeName.split(/\s-\s/)
and howtitleParts[index > 0]
are used.I'm working on a fix for this, but if you have a quick fix idea feel free to impl it yourself.
The text was updated successfully, but these errors were encountered: