Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dolt clone on tag name results in multiple issues #8377

Closed
farhanhubble opened this issue Sep 24, 2024 · 2 comments · Fixed by #8382
Closed

Dolt clone on tag name results in multiple issues #8377

farhanhubble opened this issue Sep 24, 2024 · 2 comments · Fixed by #8382

Comments

@farhanhubble
Copy link

Reproduction:

  1. On doltlab create a new tag via the "Create Release" flow, say "tag-01"
  2. Clone only this tag dolt clone origin "tag-01" <doltlab_url>
  3. Try dolt status
  4. Try dolt branch -v
  5. Try dolt log
  6. Try dolt sql -q 'select * from dolt_branches'

Current behavior:
Commands 3,4 result in unexpectedly received non-string column in 'SELECT active_branch()': %!s(<nil>). Command 5 results in this operation is not supported while in a detached head state while command 6 results in no branch data.

Expected behavior:
Either dolt clone should not work with tag names or it should leave the repo in a state where basic commands work

Dolt version: 1.43.0

@timsehn
Copy link
Contributor

timsehn commented Sep 24, 2024

Thanks. We need to copy some of the Git behavior here.

@jycor
Copy link
Contributor

jycor commented Sep 25, 2024

Hey @farhanhubble, thanks for reporting this issue.

We've improved our error handling for tags. You shouldn't be able to reference a tag in dolt clone.

dolt clone --branch tag1 <dolt-repo-url> db

Should throw an error.

We'll have a release with these changes out later this week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants