Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Docker Image to container registry #26

Open
DAcodedBEAT opened this issue Sep 9, 2024 · 1 comment
Open

Upload Docker Image to container registry #26

DAcodedBEAT opened this issue Sep 9, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@DAcodedBEAT
Copy link

Description

It would be great if the aws-ses-v2-local Docker image could be built and uploaded to DockerHub via GitHub Actions. This would make it much easier to integrate the image into various workflows without the need to build it manually each time.

Benefits

  • Streamlined integration with CI/CD pipelines.
  • Simplified usage for developers by allowing direct pulls from DockerHub.
  • Reduced setup time for new contributors and users of this project.
  • Validation that the provided Dockerfile in the repository builds correctly.

Considerations

Should the Docker image be built and pushed to DockerHub with every commit, only on new releases, or both? (Implementing both could provide the latest images for project-development purposes and stable images for general use.)

Thank you for considering this!

@domdomegg
Copy link
Owner

Thanks! Would be happy to accept a contribution for this. I think I'd prefer if it could be integrated into the package.json scripts as much as possible (rather than in GitHub Actions directly - so GitHub Actions just provides creds and calls something like npm run publish:docker).

I think the Dockerfile itself might be tidied up a little to comply with best practices for Dockerised node apps too (in terms of security, image size). But this can be done separately.

@domdomegg domdomegg added the enhancement New feature or request label Sep 15, 2024
@DAcodedBEAT DAcodedBEAT changed the title Upload Docker Image to DockerHub Upload Docker Image to container registry Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants