Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staticcheck broken on 1.9 #132

Closed
bufdev opened this issue Jul 14, 2017 · 4 comments
Closed

Staticcheck broken on 1.9 #132

bufdev opened this issue Jul 14, 2017 · 4 comments
Labels
duplicate invalid User error and other non-issues

Comments

@bufdev
Copy link

bufdev commented Jul 14, 2017

Filing this to get ahead of the curve.

$ go version
go version go1.9beta1 darwin/amd64

This is what happens when I run staticcheck:

panic: Package("runtime/cgo").Build(): unsatisfied import: Program.CreatePackage("unsafe") was not called

goroutine 866 [running]:
honnef.co/go/tools/ssa.(*Package).build(0xc425b7b4a0)
/tmp/src/honnef.co/go/tools/ssa/builder.go:2300 +0x15bb
honnef.co/go/tools/ssa.(*Package).(honnef.co/go/tools/ssa.build)-fm()
/tmp/src/honnef.co/go/tools/ssa/builder.go:2260 +0x2a
sync.(*Once).Do(0xc425b7b4cc, 0xc42b464798)
	/usr/local/Cellar/go/1.9beta1/libexec/src/sync/once.go:44 +0xbe
honnef.co/go/tools/ssa.(*Package).Build(0xc425b7b4a0)
/tmp/src/honnef.co/go/tools/ssa/builder.go:2260 +0x4c
honnef.co/go/tools/ssa.(*Program).Build.func1(0xc42788b4b0, 0xc425b7b4a0)
/tmp/src/honnef.co/go/tools/ssa/builder.go:2244 +0x2b
created by honnef.co/go/tools/ssa.(*Program).Build
/tmp/src/honnef.co/go/tools/ssa/builder.go:2243 +0x11a
@dominikh
Copy link
Owner

What revision of staticcheck are you running?

@bufdev
Copy link
Author

bufdev commented Jul 14, 2017

f583b58 apparently, which I think is the latest commit https://github.com/yarpc/yarpc-go/blob/dev/glide.lock#L278

@bufdev
Copy link
Author

bufdev commented Jul 14, 2017

Hmm, when I upgrade to 1.9beta2, this no longer happens. Feel free to close this if it's not an issue for you.

@dominikh
Copy link
Owner

Seeing how this is a duplicate of #76 it probably was unrelated to the upgrade of Go :)

@dominikh dominikh marked this as a duplicate of #76 Jul 14, 2017
@dominikh dominikh added the invalid User error and other non-issues label Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate invalid User error and other non-issues
Projects
None yet
Development

No branches or pull requests

2 participants