Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work well with proxy classes #218

Open
MaybeThisIsRu opened this issue May 2, 2022 · 1 comment
Open

Does not work well with proxy classes #218

MaybeThisIsRu opened this issue May 2, 2022 · 1 comment

Comments

@MaybeThisIsRu
Copy link
Contributor

MaybeThisIsRu commented May 2, 2022

When using with proxy classes, this package does not work well. Some improvements that can be made:

  • Admin list display can refer to the proxy class instead of the parent class
  • Admin list filter can refer to the proxy class instead of the parent class
  • Documentation
    • After some monkey patching, I have realised that even though the package was telling me that the parent class was not registered with Moderation and that I should register it, there's no such need. We should be able to register all the proxy classes alone, without the parent class.
      • Registering both would break the app. Save handling or change/delete pages also break depending on which one you'd register (say, parent class) and which one you won't (say, proxy classes).

I'm unlikely to PR these changes yet as I'm testing them on my project internally.

@MaybeThisIsRu
Copy link
Contributor Author

https://github.com/MaybeThisIsRu/django-moderation/tree/proxy-models

This seems to work, but a PR is not yet in the plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant