Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative url()s to files within src/ do not work #59

Closed
phillipskevin opened this issue Apr 10, 2017 · 3 comments
Closed

Relative url()s to files within src/ do not work #59

phillipskevin opened this issue Apr 10, 2017 · 3 comments

Comments

@phillipskevin
Copy link
Contributor

If you create a url() from an image that is within your project's src/ folder like:

background-image: url("./assets/1-banner.jpg");

in DoneJS 0.9, the CSS that is injected into the SSR'd page would have:

background-image: url(/src/assets/1-banner.jpg);

in DoneJS 1.0, the SSR'd page has

background-image: url("assets/1-banner.jpg");

which is not correct.

@phillipskevin
Copy link
Contributor Author

In done-css 2, this was handled here: https://github.com/donejs/css/blob/v2.0.3/css.js#L107-L109.

@phillipskevin
Copy link
Contributor Author

phillipskevin commented Apr 10, 2017

done-css is using steal-css now and this code is skipped during SSR: https://github.com/stealjs/steal-css/blob/master/css.js#L157-L163.

@phillipskevin
Copy link
Contributor Author

This is fixed in steal-css@1.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant