-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize removes leaf nodes with --prune-leaves false #1426
Comments
Hi @bobbens! Part of the issue here is that I would have expected that The 'optimize' command takes the "kitchen sink" approach here; joining meshes, instancing meshes, and flattening the scene graph might all be difficult to square with preserving a particular empty node somewhere in that scene graph. So, I'll keep this issue open, but you may find it easier to pick and choose the optimizations you want, either with individual CLI commands, a custom CLI config, or the scripting interface. |
Thank you for the suggestions. I would assume I would like to keep on using the "kitchen sink", as this is part of a blender -> gltf production chain, and it seems like it should be lower maintenance in the long run compared with having to modify or edit scripts to update functionality. I'll try to wait for a resolution as I'm not necessarily in a hurry at the moment. Thanks for the good work on gltf-transform! |
Describe the bug
gltf-transform optimize --prune false
/gltf-transform optimize --prune-leaves false
removes leaf nodes from a gltf, whilegltf-transform prune --keep-leaves true
works as expected and keeps the leaf nodes (although without--keep-leaves true
in prunes them).To Reproduce
Steps to reproduce the behavior:
/tmp/test.gltf
:gltf-transform optimize --prune-leaves false /tmp/test.gltf /tmp/out.gltf
/tmp/out.gltf
.Expected behavior
The leaf nodes should be kept, as done by
gltf-transform prune --keep-leaves true /tmp/test.gltf /tmp/out.gltf
Versions:
Additional context
The following command
gltf-transform optimize --prune-leaves false --flatten false --weld false --simplify false --join false /tmp/test.gltf /tmp/out.gltf
does work, however, it disables too much functionality.The text was updated successfully, but these errors were encountered: