Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to remove EXT_GPU_INSTANCING usage #1493

Closed
gkjohnson opened this issue Aug 30, 2024 · 3 comments · Fixed by #1525
Closed

Add ability to remove EXT_GPU_INSTANCING usage #1493

gkjohnson opened this issue Aug 30, 2024 · 3 comments · Fixed by #1525
Labels
feature New enhancement or request package:functions
Milestone

Comments

@gkjohnson
Copy link

Is your feature request related to a problem? Please describe.

Right now you can convert a model to use EXT_GPU_INSTANCING instances using the instance command but this is not supported by a lot of engines (Unreal, other tools). It would be nice if it were possible to remove the extension usage in cases where you don't want it / can't use it.

Describe the solution you'd like

  • Add a "--remove-instances" option to the "gltf-transform instance" command
  • Or unpack instances and recompute them based on the settings of the instance command. Ie running a model that already has instances with the following command would remove all instances:
gltf-transform input.glb output.glb --min 10000000

Describe alternatives you've considered

Reading into the three.js editor and unpacking all instances manually.

Additional context

None

@gkjohnson gkjohnson added the feature New enhancement or request label Aug 30, 2024
@donmccurdy
Copy link
Owner

I like the idea! This would involve:

  • add an uninstance() (deinstance?) transform to the /functions package
  • add a new command or flag to the CLI

I'm not immediately able to work on this, but PRs would be welcome.

@donmccurdy donmccurdy added help wanted Extra attention is needed package:functions labels Aug 30, 2024
@donmccurdy donmccurdy added this to the 🗄️ Backlog milestone Aug 30, 2024
@donmccurdy donmccurdy modified the milestones: 🗄️ Backlog, v4.1 Oct 10, 2024
@donmccurdy donmccurdy removed the help wanted Extra attention is needed label Oct 10, 2024
@donmccurdy
Copy link
Owner

In progress:

@gkjohnson
Copy link
Author

Awesome! Thanks Don

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New enhancement or request package:functions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants