Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifier omitting some issues and labels #42

Open
r12a opened this issue May 2, 2018 · 1 comment
Open

Notifier omitting some issues and labels #42

r12a opened this issue May 2, 2018 · 1 comment

Comments

@r12a
Copy link
Contributor

r12a commented May 2, 2018

I've noticed a couple of times recently that new issues have not found their way into email notifications.

Here's an example from today's notifications. w3c/i18n-issues#2

It should have been listed at https://lists.w3.org/Archives/Public/public-i18n-cjk/2018AprJun/0007.html with the others.

The rule is:

"public-i18n-cjk@w3.org": {
   	"digest:daily": [ 
            { 
            "topic": "cjklreq repos",
            "repos": ["w3c/clreq","w3c/jlreq","w3c/klreq"]
            },
            { 
            "topic": "W3C specs (CJK)",
            "repos": ["w3c/csswg-drafts", "w3c/html", "w3c/ttml2", "w3c/i18n-issues"],
            "eventFilter": {"label": ["i18n-clreq", "i18n-jlreq", "i18n-klreq"]}
            }
            ]
},

The only difference i can see between this issue and the others that got through is that it has two labels, rather than one. No idea whether that is significant.

However, this was notified via another rule to https://lists.w3.org/Archives/Public/www-international/2018AprJun/0033.html. Interestingly, no labels are shown next to the link in that notification.

Seems odd, since the labels were set at around the same time as the issue was created.

This is, obviously, a significant problem when it comes to tracking new comments. Any idea where the problem originates?

@dontcallmedom
Copy link
Owner

So, the problem is that the digest notifier looks at the labels on the issue at the time of its creation, not labels that might have been added after the issue is created.

I'll need to think some more as to what the right behavior should be given the intended usage here and elsewhere (input welcome though!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants