Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finishTransaction should take purchase instead of transaction ID #797

Closed
mars-lan opened this issue Oct 15, 2019 · 1 comment · Fixed by #833
Closed

finishTransaction should take purchase instead of transaction ID #797

mars-lan opened this issue Oct 15, 2019 · 1 comment · Fixed by #833
Labels
1️⃣ good first issue Good for newcomers

Comments

@mars-lan
Copy link
Contributor

The newly added finishTransaction takes "transaction ID" as its first argument (https://github.com/dooboolab/react-native-iap/blob/master/index.ts#L401), whereas in reality, the user should pass in "purchase token" in the case Android non-consumable (https://github.com/dooboolab/react-native-iap/blob/master/index.ts#L418). I'd recommend refactoring the method to take purchase object instead to make it truly platform-neutral.

@hyochan
Copy link
Owner

hyochan commented Oct 17, 2019

Thanks! Sounds very reasonable. We'll refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1️⃣ good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants