Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a wrong package.json setting #1377

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Fix a wrong package.json setting #1377

merged 1 commit into from
Jun 15, 2021

Conversation

ifsnow
Copy link
Contributor

@ifsnow ifsnow commented Jun 15, 2021

The value of main property in package.json is "index.ts".
I think this is problematic. For example, Flow throws a "Cannot resolve module" error.

@hyochan hyochan added the 🛠 bugfix All kinds of bug fixes label Jun 15, 2021
hyochan
hyochan approved these changes Jun 15, 2021
View reviewed changes
Copy link
Owner

@hyochan hyochan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG! This is definitely a problem. It is also a wrong config on the ts side either.

I think I've missed this during review 😞 .

Thank you for the fixes 🙏

@hyochan hyochan merged commit cb1bf23 into hyochan:master Jun 15, 2021
@hyochan hyochan mentioned this pull request Jun 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyochan hyochan hyochan approved these changes

Assignees
No one assigned
Labels
🛠 bugfix All kinds of bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ifsnow @hyochan