fixes java lint errors and adds check to CI #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresesfm
added
dependencies
added 2 commits
June 16, 2021 17:00
hyochan
approved these changes
Jun 19, 2021
| @@ -28,14 +28,15 @@ jobs: | |||
|
|
|||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - name: Set up JDK 1.8 | |||
| uses: actions/setup-java@v1 | |||
| - name: Set up JDK 11 | |||
There was a problem hiding this comment.
Why 11 and not 14 if you want to upgrade?
There was a problem hiding this comment.
11 is the one that ships with Android studio and the one needed to run the Google check style gradle plugin 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.