Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent crashing from phones that doesn't have IAP feature #434

Merged
merged 4 commits into from
Mar 22, 2019
Merged

Prevent crashing from phones that doesn't have IAP feature #434

merged 4 commits into from
Mar 22, 2019
+127 −29

Conversation

rinku-k
Copy link
Contributor

@rinku-k rinku-k commented Mar 22, 2019

These Additional checks will help in pushing code accessing RNIap plugin to SDK that does not have the plugin in it.

I am sure this will help other developers also to push code remotely without any breakage

hyochan
hyochan requested changes Mar 22, 2019
View reviewed changes
Copy link
Owner

@hyochan hyochan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should avoid using this since there isn't any class instance in index.js. Also some tests are failing please try running npm run lint && cd RNIapExample && npm run lint and fix some lints for us.

@hyochan
Copy link
Owner

hyochan commented Mar 22, 2019 •
edited
Loading

@Rinkuk1993 Thank you for the contribution 👍. This feature is definitely needed to supports phones that doesn't support IAP as well as Code Push. Please update few codes I've mentioned above.

@rinku-k
Copy link
Contributor Author

rinku-k commented Mar 22, 2019

Sure. Thanks for the feedback. I will correct the code and push again

hyochan
hyochan approved these changes Mar 22, 2019
View reviewed changes
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Approve this PR.

hyochan
hyochan requested changes Mar 22, 2019
View reviewed changes
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rinkuk1993 Could you do me one last favor? Since there is some conflict with master branch, I would like you to rebase your code to our master branch and push once more.

@rinku-k
Copy link
Contributor Author

rinku-k commented Mar 22, 2019

You can check now. Rebase is done and pushed

hyochan
hyochan approved these changes Mar 22, 2019
View reviewed changes
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hyochan hyochan merged commit 21c4a6b into hyochan:master Mar 22, 2019
@hyochan hyochan added the 🍗 enhancement New feature or request label Mar 22, 2019
@hyochan hyochan changed the title Supporting code push Prevent crashing from phones that doesn't have IAP feature Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyochan hyochan hyochan approved these changes

Assignees
No one assigned
Labels
🍗 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rinku-k @hyochan