Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradle api usage #489

Merged
merged 1 commit into from
May 18, 2019
Merged

Fix gradle api usage #489

merged 1 commit into from
May 18, 2019

Conversation

alpha0010
Copy link
Contributor

Currently, local configuration of versions is ignored by this library.

hasProperty() exists on the Project object itself; Project.ext uses has().

You can test by modifying the main app's build.gradle.

buildscript {
    ext {
        buildToolsVersion = "28.0.3"
// [...]

With this mr, setting buildToolsVersion to something older will result in a warning during build. On current master, changes to buildToolsVersion have no effect.

@hyochan hyochan added 🤖 android Related to android 👷‍♀️ build Build issue labels May 18, 2019
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you are right! Thanks for your kind explanation! 👍

@hyochan hyochan merged commit 2b82dd0 into hyochan:master May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android Related to android 👷‍♀️ build Build issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants