Remove getOrderId from PurchaseHistory #554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `size()` instead of `length` for `purchases` List
Fix purchases.size
upstream
Use `getOrderId` instead of `getPurchaseToken` to be identical to `onPurchasesUpdated`
upstream to 3.1.1
PurchaseHistoryRecord doesn't have getOrderId
hyochan
reviewed
Jun 22, 2019
| // item.putString("transactionId", purchase.getOrderId()); | ||
| // PurchaseHistoryRecord doesn't have orderId, | ||
| // and it seems that getOriginalJson in this case also doesn't return the orderId | ||
| // is there any way to obtain this? |
There was a problem hiding this comment.
Not in android's billing client version 2. Why not using getPurchases instead to acquire this?
|
My Java knowledge is limited, I removed this for now as it crashes otherwise 😞
…Sent from my iPhone
On 22 Jun 2019, at 14:27, Hyo Chan Jang ***@***.***> wrote:
@hyochan commented on this pull request.
In android/src/main/java/com/dooboolab/RNIap/RNIapModule.java:
> @@ -319,7 +319,12 @@ public void onPurchaseHistoryResponse(BillingResult billingResult, List<Purchase
for (PurchaseHistoryRecord purchase : purchaseHistoryRecordList) {
WritableMap item = Arguments.createMap();
item.putString("productId", purchase.getSku());
- item.putString("transactionId", purchase.getOrderId());
+
+ // item.putString("transactionId", purchase.getOrderId());
+ // PurchaseHistoryRecord doesn't have orderId,
+ // and it seems that getOriginalJson in this case also doesn't return the orderId
+ // is there any way to obtain this?
Not in android's billing client version 2. Why not using getPurchases instead to acquire this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@rborn Yes removing should be accepted. Can I merge this now? |
|
@rborn This repo doesn't seem to be |
|
@hyochan thank you ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PurchaseHistoryRecord doesn't have orderId