Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return correct Subscription[] type for getSubscriptions #746

Merged
merged 2 commits into from
Oct 1, 2019
Merged

Return correct Subscription[] type for getSubscriptions #746

merged 2 commits into from
Oct 1, 2019

Conversation

jvandenaardweg
Copy link
Contributor

Fixes #744

@hyochan hyochan added 🛠 bugfix All kinds of bug fixes ❄️ types Typing issues labels Oct 1, 2019
hyochan
hyochan approved these changes Oct 1, 2019
View reviewed changes
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix again! 👍

@hyochan hyochan merged commit 8ff94b4 into hyochan:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyochan hyochan hyochan approved these changes

Assignees
No one assigned
Labels
🛠 bugfix All kinds of bug fixes ❄️ types Typing issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getSubscriptions returns wrong type
2 participants
@jvandenaardweg @hyochan