Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] added subs to the list of unconsumed purchases #807

Merged
merged 1 commit into from
Oct 25, 2019

Conversation

ancyrweb
Copy link

sendUnconsumedPurchases only send unconsumed in-app products but not subscriptions. The app i'm working on uses subscriptions and requires to be able to send receipt to the server about unacknowledged subscriptions. This fixes it.

I also saw that a promise is passed as a parameter but isn't subscribed to inside index.ts. As is, this promise is useless so I decided to resolve it with true no matter what at the end of the function.

@hyochan
Copy link
Owner

hyochan commented Oct 24, 2019

@emilioicai Could you kindly help reviewing this?

@hyochan hyochan requested a review from emilioicai October 24, 2019 14:28
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me~!

@hyochan hyochan added the 🍗 enhancement New feature or request label Oct 25, 2019
@hyochan hyochan merged commit bfca054 into hyochan:master Oct 25, 2019
@hyochan hyochan mentioned this pull request Oct 25, 2019
hyochan added a commit that referenced this pull request Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍗 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants