This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
SQL query incidents regexp refers to none valid JSON string for github issues #421
Labels
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
https://github.com/GoogleCloudPlatform/fourkeys/blob/9e04246183bc8bbd854467262c1f6a7526dfcdfb/queries/incidents.sql#L26
Apparently
'"name":"Incident"'
is not a valid JSON string. As double quotes should be escaped within JSON strings ...So metadata chunk for
issue.labels
should be either this:with back quotes escaping:
or this:
without quotes at all:
In either way current regexp does not search these cases. And for the second case it could be
'name:Incident'
The text was updated successfully, but these errors were encountered: