Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyKey GUIDs Incorrect/Missing; No PID Info #2

Open
CaiB opened this issue Apr 28, 2020 · 0 comments
Open

PropertyKey GUIDs Incorrect/Missing; No PID Info #2

CaiB opened this issue Apr 28, 2020 · 0 comments

Comments

@CaiB
Copy link

CaiB commented Apr 28, 2020

Hello,

It appears that the GUID specified in PropertyKeys.cs for PKEY_DeviceInterface_FriendlyName is incorrectly named, as it is actually PKEY_Device_xxx.

Additionally, the two other common device PropertyKey GUIDs are absent, as found in the Microsoft docs. They are PKEY_DeviceInterface_FriendlyName(the actual one), and PKEY_Device_DeviceDesc.

I believe the corrected/added values are as follows:

PKEY_Device_FriendlyName = new Guid(0xa45c254e, 0xdf1c, 0x4efd, 0x80, 0x20, 0x67, 0xd1, 0x46, 0xa8, 0x50, 0xe0); // PID 14
PKEY_DeviceInterface_FriendlyName = new Guid(0x026e516e, 0xb814, 0x414b, 0x83, 0xcd, 0x85, 0x6d, 0x6f, 0xef, 0x48, 0x22); // PID 2
PKEY_Device_DeviceDesc = new Guid(0xa45c254e, 0xdf1c, 0x4efd, 0x80, 0x20, 0x67, 0xd1, 0x46, 0xa8, 0x50, 0xe0); // PID 2

Side note, I don't see anywhere where the PID values are defined. Is this intentional? The information currently given in PropertyKeys.cs isn't actually enough to uniquely identify the properties without the user referencing PID values from the Windows API headers. (e.g. the GUIDs for Device_FriendlyName and Device_DeviceDesc are the same, you need the different PID values in order to actually get the right info)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant