Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support comma separated list-files enum #67

Closed
paulius-p opened this issue Feb 18, 2021 · 3 comments · Fixed by #68
Closed

Support comma separated list-files enum #67

paulius-p opened this issue Feb 18, 2021 · 3 comments · Fixed by #68
Labels
enhancement New feature or request

Comments

@paulius-p
Copy link

There are quite a few cases were you need to provide a comma separated list of files for cli arguments or properties. So I think it would be good to be able to define it in the action, rather that doing sed.

@dorny
Copy link
Owner

dorny commented Feb 18, 2021

Good idea. There's not much work to implement it. I will add it soon 👍

@dorny
Copy link
Owner

dorny commented Feb 18, 2021

Actually there's an easy way how to do it in current version.

Use list-files: json and afterwards you can get coma separated list like this:
join(fromJSON(steps.filter.outputs.FILTER_NAME_files))

list-files: json - enables file listing using JSON format, still every action output is just a string
fromJSON() - will parse that string into actual JSON array
join - will concatenate array using default separator ,

Does it work for you or is there anything missing?

@paulius-p
Copy link
Author

Sure, that's a possible workaround, though I think it would be much cleaner and less verbose if there would be an option in the action. Though it's up to you :)

@dorny dorny added the enhancement New feature or request label Feb 20, 2021
@dorny dorny closed this as completed in #68 Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants