Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate GraphQL bindings from REST APIs #28

Closed
nikolasburk opened this issue Jan 12, 2018 · 9 comments
Closed

Generate GraphQL bindings from REST APIs #28

nikolasburk opened this issue Jan 12, 2018 · 9 comments
Assignees

Comments

@nikolasburk
Copy link
Contributor

It should be possible to transform any REST API into a GraphQL binding, based on some kind of structured API documentation, such as Swagger / Open API docs.

Open questions:

  • What kind of REST API tooling provides/generates a structured documentation that could be used as a foundation to generate the GraphQL schema?
@kbrandwijk
Copy link
Contributor

I checked this out a bit more. The OpenAPI specification should be the basis for this. Swagger has https://github.com/swagger-api/swagger-codegen, which is a collection of many, many, generators for clients, servers, etc. I think generating a GraphQL binding should be one of those generators. I will look into this in more detail, and draft a proposal.

@ntziolis
Copy link

Not sure how extensive this covers all cases but this package seems to be fairly actively used:
https://www.npmjs.com/package/swagger-to-graphql

Anybody experience with this lib?

@kbrandwijk
Copy link
Contributor

kbrandwijk commented Jan 16, 2018

@ntziolis Thank you very much for pointing to that library. It looks good, and seems easily integratable with graphql-binding and yoga (by using the schema it exposes as input for graphql-binding and adding that proxyURL to the context in yoga). I'll put it on my list to experiment with it.

@kbrandwijk kbrandwijk self-assigned this Jan 16, 2018
@ntziolis
Copy link

The key and graphcool specific piece will be to handle things like pagination, aggregates etc. For that I would suggest using an architecture that allows for all graphql implementations to share a common base and to allow it to be configurable for each implementation. lmk how experiments go I'm happy to help. This is on top of my current want to have list.

@export-mike
Copy link

this project just keeps on giving! 👀 "following"

@kbrandwijk
Copy link
Contributor

I am currently looking to go down the following path. I will release a openapi specific version of graphql-binding (similar to graphql-binding-github), that uses swagger-to-graphql internally. This way, you will be able to set up a binding like this:

import { Binding } from 'graphql-binding-openapi'
...
context: req => {
    myBinding: new Binding({ definition: './definition.json', endpoint: 'http://myserver.....' })
}
...

@kbrandwijk
Copy link
Contributor

The binding is released: https://github.com/graphql-binding/graphql-binding-openapi. Please feel free to open an issue on that repo for additional questions/requests/issues regarding REST API support.

@ntziolis
Copy link

Wow tust was a Quick Turn around!

@Urigo
Copy link
Collaborator

Urigo commented May 26, 2020

In the last few months, since the transition of many libraries under The Guild's leadership, We've reviewed and released many improvements and versions to graphql-cli, graphql-config and graphql-import.

We've reviewed graphql-binding, had many meetings with current users and engaged the community also through the roadmap issue.

What we've found is that the new GraphQL Mesh library is covering not only all the current capabilities of GraphQL Binding, but also the future ideas that were introduced in the original GraphQL Binding blog post and haven't come to life yet.

And the best thing - GraphQL Mesh gives you all those capabilities, even if your source is not a GraphQL service at all!
it can be GraphQL, OpenAPI/Swagger, gRPC, SQL or any other source!
And of course you can even merge all those sources into a single SDK.

Just like GraphQL Binding, you get a fully typed SDK (thanks to the protocols SDKs and the GraphQL Code Generator), but from any source, and that SDK can run anywhere, as a connector or as a full blown gateway.
And you can share your own "Mesh Modules" (which you would probably call "your own binding") and our community already created many of those!
Also, we decided to simply expose regular GraphQL, so you can choose how to consume it using all the awesome fluent client SDKs out there.

If you think that we've missed anything from GraphQL Binding that is not supported in a better way in GraphQL Mesh, please let us know!


In the context of that particular issue - Supporting REST was the original goal of GraphQL Mesh so I'm pretty sure we cover that use case very nicely.
But, if you think something might be missing in GraphQL Mesh, please feel free to open a new issue on the GraphQL Mesh repo.

We're looking forward for your feedback of how we can make your experience even better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants