Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make extractFragmentReplacements work automatically #35

Closed
kbrandwijk opened this issue Jan 26, 2018 · 6 comments
Closed

Make extractFragmentReplacements work automatically #35

kbrandwijk opened this issue Jan 26, 2018 · 6 comments
Assignees

Comments

@kbrandwijk
Copy link
Contributor

Right now, you need to call extractFragmentReplacements on your resolvers manually, and pass them in to your binding. This is a confusing step, that should not be necessary.

@kbrandwijk kbrandwijk self-assigned this Jan 26, 2018
@kbrandwijk
Copy link
Contributor Author

This is actually a bigger issue. Because the same mechanism used for extractFragmentReplacements should also be applied to other resolver fields, like __resolveType. This is crucial for supporting Union Types in bindings (reported by @idibidiart).

@lastmjs
Copy link

lastmjs commented Mar 13, 2018

Yes, please get rid of this, it is awkward

@schickling
Copy link
Contributor

Like @kbrandwijk this is a bit of a bigger topic which we need to further look into. @lastmjs I completely agree with you that this is complexity that ideally should be hidden.

Do you (or someone else) have any thoughts how this could be accomplished?

cc @freiksenet

@freiksenet
Copy link

It's a separate transform in next-api, so it should be easier to apply. Unions/interfaces can also be supported through transform. I'm not sure what's the best way to extract the transforms in your case though.

@freiksenet
Copy link

Though I think we should discuss how the transform extraction would happen in binding case. I guess you could generate some of them, but there would need to be a step to do that generation or you need to close over delegateToSchema the same way it's done in mergeSchemas.

@Urigo
Copy link
Collaborator

Urigo commented May 26, 2020

Thank you for reporting.

In the last few months, since the transition of many libraries under The Guild's leadership, We've reviewed and released many improvements and versions to graphql-cli, graphql-config and graphql-import.

We've reviewed graphql-binding, had many meetings with current users and engaged the community also through the roadmap issue.

What we've found is that the new GraphQL Mesh library is covering not only all the current capabilities of GraphQL Binding, but also the future ideas that were introduced in the original GraphQL Binding blog post and haven't come to life yet.

And the best thing - GraphQL Mesh gives you all those capabilities, even if your source is not a GraphQL service at all!
it can be GraphQL, OpenAPI/Swagger, gRPC, SQL or any other source!
And of course you can even merge all those sources into a single SDK.

Just like GraphQL Binding, you get a fully typed SDK (thanks to the protocols SDKs and the GraphQL Code Generator), but from any source, and that SDK can run anywhere, as a connector or as a full blown gateway.
And you can share your own "Mesh Modules" (which you would probably call "your own binding") and our community already created many of those!
Also, we decided to simply expose regular GraphQL, so you can choose how to consume it using all the awesome fluent client SDKs out there.

If you think that we've missed anything from GraphQL Binding that is not supported in a better way in GraphQL Mesh, please let us know!


In the context of that particular issue - GraphQL Mesh uses the new schema stitching introduced in GraphQL Tools v6.
I believe it should cover your schema transform use case but if not, please let me know!

We're looking forward for your feedback of how we can make your experience even better!

@Urigo Urigo closed this as completed May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants