Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested fields input arguments are ignored #61

Closed
pie6k opened this issue Mar 10, 2018 · 2 comments
Closed

Nested fields input arguments are ignored #61

pie6k opened this issue Mar 10, 2018 · 2 comments

Comments

@pie6k
Copy link

pie6k commented Mar 10, 2018

My schema allows login like:

mutation {
  auth {
    login(input: { email: "aaa", password: "aaa" }) {
      token
    }
  }
}

However, generated binding is ignoring input argument for login field. It is only allowing arguments on root mutation and query field and that is pretty much making it useless for my use-case.

My config:

{
  "projects":{
    "XYZ":{
      "schemaPath":"src/schema/api.graphql",
      "extensions":{
        "endpoints": {
          "dev":"http://localhost:9000/api/"
        },
        "prepare-binding": {
          "output": "src/schema/api.ts",
          "generator": "binding-ts"
        }
      }
    }
  }
}

I'd like to use binding like

binding.mutation.auth.login(inputDataHere)

or as async

const auth = await binding.mutation.auth();
auth.login(inputDataHere)`;

// or even (await binding.mutation.auth()).login(data)
@pie6k pie6k changed the title Nested fields ignore input arguments Nested fields input arguments are ignored Mar 10, 2018
@fgrehm
Copy link

fgrehm commented Nov 23, 2018

Seems to be related to #17

@Urigo
Copy link
Collaborator

Urigo commented May 26, 2020

Thank you for reporting.

In the last few months, since the transition of many libraries under The Guild's leadership, We've reviewed and released many improvements and versions to graphql-cli, graphql-config and graphql-import.

We've reviewed graphql-binding, had many meetings with current users and engaged the community also through the roadmap issue.

What we've found is that the new GraphQL Mesh library is covering not only all the current capabilities of GraphQL Binding, but also the future ideas that were introduced in the original GraphQL Binding blog post and haven't come to life yet.

And the best thing - GraphQL Mesh gives you all those capabilities, even if your source is not a GraphQL service at all!
it can be GraphQL, OpenAPI/Swagger, gRPC, SQL or any other source!
And of course you can even merge all those sources into a single SDK.

Just like GraphQL Binding, you get a fully typed SDK (thanks to the protocols SDKs and the GraphQL Code Generator), but from any source, and that SDK can run anywhere, as a connector or as a full blown gateway.
And you can share your own "Mesh Modules" (which you would probably call "your own binding") and our community already created many of those!
Also, we decided to simply expose regular GraphQL, so you can choose how to consume it using all the awesome fluent client SDKs out there.

If you think that we've missed anything from GraphQL Binding that is not supported in a better way in GraphQL Mesh, please let us know!


In the context of that particular issue - I believe we respect input arguments in nested fields in GraphQL Mesh.
If you think not, please feel free to open a new issue on the GraphQL Mesh repo.

We're looking forward for your feedback of how we can make your experience even better!

@Urigo Urigo closed this as completed May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants