Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emphasize usage of Repeater in the documentation/tutorial #2672

Open
Tracked by #2700 ...
n1ru4l opened this issue Apr 12, 2023 · 3 comments
Open
Tracked by #2700 ...

Emphasize usage of Repeater in the documentation/tutorial #2672

n1ru4l opened this issue Apr 12, 2023 · 3 comments

Comments

@n1ru4l
Copy link
Collaborator

n1ru4l commented Apr 12, 2023

We should teach people that this is the recommended way of dealing with AsyncGenerators as it solves a lot of leak issues.

This was referenced May 7, 2024
This was referenced May 23, 2024
@tslater
Copy link

tslater commented Sep 22, 2024

@n1ru4l is this already done? It seemed emphasized in the docs when I read it.

@protometa
Copy link

I am curious about what kinds of leaks are cause by generators. I can see in the example, when setting an Interval you would need a means of clearing it, but most other things can be garbage collected along with the generator correct?

@tslater
Copy link

tslater commented Oct 10, 2024

I'd also recommend that the recommendation be simpler and stronger...why show generators in the first place? You could mention generators + leaks but I'd leave off the code example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants