Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node_exporter metrics for node CPU #16

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Jul 16, 2022

Pull Request

Required Fields

🔎 What kind of change is it?

  • fix

🎯 What has been changed and why do we need it?

  • Use the node_exporter CPU metrics to get system level data.

Optional Fields

✔️ Which issue(s) this PR fixes?

💬 Additional information?

  • ...

Use the node_exporter CPU metrics to get system level data.

Fixes: dotdc#3

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ requested a review from dotdc as a code owner July 16, 2022 15:52
@dotdc
Copy link
Owner

dotdc commented Jul 16, 2022

Thank you @SuperQ, will test this when I can 👍

@@ -686,7 +686,7 @@
},
"editorMode": "code",
"exemplar": true,
"expr": "sum(rate(container_cpu_usage_seconds_total{id=\"/\"}[$__rate_interval]))",
"expr": "sum(1-rate(node_cpu_seconds_total{mode=\"idle\"}}[$__rate_interval]))",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch

Copy link
Owner

@dotdc dotdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dotdc dotdc merged commit 27e4577 into dotdc:master Jul 18, 2022
@dotdc
Copy link
Owner

dotdc commented Apr 25, 2024

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dotdc dotdc added the released label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some metrics are missing.
2 participants