Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add heatmaps for CoreDNS histogram metrics #34

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Add heatmaps for CoreDNS histogram metrics #34

merged 1 commit into from
Nov 25, 2022

Conversation

geekofalltrades
Copy link
Contributor

Pull Request

Required Fields

🔎 What kind of change is it?

  • feat

🎯 What has been changed and why do we need it?

  • Added heatmaps for CoreDNS histogram metrics that were previously not being visualized.

heatmaps

Optional Fields

✔️ Which issue(s) this PR fixes?

  • N/A

💬 Additional information?

  • We don't use kube-prometheus-stack, so this is not validated to work there. But it does work with our CoreDNS deployment, which works with the rest of this dashboard.

dotdc
dotdc approved these changes Nov 25, 2022
View reviewed changes
Copy link
Owner

@dotdc dotdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dotdc dotdc merged commit da7440e into dotdc:master Nov 25, 2022
@dotdc
Copy link
Owner

dotdc commented Nov 25, 2022

Thank you for your contribution @geekofalltrades!

@dotdc dotdc mentioned this pull request Apr 11, 2024
Closed
@dotdc
Copy link
Owner

dotdc commented Apr 25, 2024

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dotdc dotdc added the released label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotdc dotdc dotdc approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geekofalltrades @dotdc