Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dashboard showing metrics from nodes outside of kubernetes cluster #36

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

tlemarchand
Copy link
Contributor

Pull Request

Required Fields

🔎 What kind of change is it?

  • fix

🎯 What has been changed and why do we need it?

  • Currently the global views show metrics from all nodes. If Prometheus is used to gather metrics from nodes that are not part of the kubernetes cluster, the metrics showed are wrong. This PR fixes this problem. Also, it increase coherence with line 332 which already includes such a filter.

Optional Fields

✔️ Which issue(s) this PR fixes?

  • ...

💬 Additional information?

  • ...

@tlemarchand tlemarchand requested a review from dotdc as a code owner January 11, 2023 08:56
Copy link
Owner

@dotdc dotdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dotdc dotdc merged commit 95e014e into dotdc:master Jan 11, 2023
@dotdc
Copy link
Owner

dotdc commented Jan 11, 2023

Thank you for your contribution @tlemarchand !

Just to know, do you have the same problem on the node view?

@tlemarchand
Copy link
Contributor Author

@dotdc : no problem on the node view, only nodes from cluster are shown.

Thank you for theses dashboards, very useful.

@dotdc
Copy link
Owner

dotdc commented Apr 25, 2024

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants