count nodes by kube_node_info, instead of node-exporter jobs #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The metric `up{job="node-exporter"}` does not exist when using Grafana Agent. Counting `kube_node_info` should be agnostic and more reliable.
Fixes dotdc#46
dotdc
approved these changes
May 26, 2023
|
Thank you for your contribution! |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Required Fields
🔎 What kind of change is it?
🎯 What has been changed and why do we need it?
up{job="node-exporter"}does not exist when using Grafana Agent. Countingkube_node_infoshould be agnostic and more reliable.Optional Fields
✔️ Which issue(s) this PR fixes?
💬 Additional information?