Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper implode syntax #309

Closed
danmentzer opened this issue Mar 7, 2019 · 2 comments
Closed

Improper implode syntax #309

danmentzer opened this issue Mar 7, 2019 · 2 comments

Comments

@danmentzer
Copy link

I believe i had a support ticket with dotmailer previously about this issue.
Just pulled the latest release from the repo.
app/code/community/Dotdigitalgroup/Email/Model/Connector/Order.php

Line 536 $value = implode($value, ', ');

That line should be
$value = implode(',',$value);

I came across this while reviewing the latest release 6.4.11.

@adeelq
Copy link
Contributor

adeelq commented Mar 8, 2019

@danmentzer Thanks for reporting this. We have added this to out current sprint. Will update you when it is released.

@adeelq
Copy link
Contributor

adeelq commented Mar 13, 2019

This is now release in latest version.

@adeelq adeelq closed this as completed Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants